Add -W (--allow-write) to deno build instructions #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jan 31, 2025
README.md
Outdated
|
|
||
| ```shell | ||
| deno run -ERN jsr:@bids/validator | ||
| deno run -ERNW jsr:@bids/validator |
Contributor
There was a problem hiding this comment.
Just because RW is a meaningful sequence:
Suggested change
| deno run -ERNW jsr:@bids/validator | |
| deno run -ERWN jsr:@bids/validator |
And note that the meanings of -E, -R and -N are described in the next paragraph. Could you add -W?
Contributor
There was a problem hiding this comment.
Also we could mention that -A allows all permissions, if this is getting long.
Contributor
Author
There was a problem hiding this comment.
done for 1st comment. I would not bother with -A as not used here/not directly relevant to this PR ;)
Without that run which asks to save results into external file would fail with error: Uncaught (in promise) PermissionDenied: Requires write access to "derivatives/bids-validator/deno-bids-validator.txt", specify the required permissions during compilation using `deno compile --allow-write` at writeFileSync (ext:deno_fs/30_fs.js:899:3) at Object.writeTextFileSync (ext:deno_fs/30_fs.js:962:10) at main (https://jsr.io/@bids/validator/2.0.1/src/main.ts:38:12) at eventLoopTick (ext:core/01_core.js:175:7) at async https://jsr.io/@bids/validator/2.0.1/src/bids-validator.ts:2:16 === Do not change lines below === { "chain": [], "cmd": "git-sedi ' -ERN' ' -ERWN'", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that run which asks to save results into external file would fail with
There is also
--allow-runwhich I do not know if should be enabled or not -- e.g. do you run HED validator as external tool, or anything else?Is it possible to identify such needs at compile time?